v3.27 Named font-sizes - Page 1

I've evaluated already some number of PHP libraries and html2pdf seems to be have the highest quality. But even it has some issues:
It looks like html2pdf does not support subj. by that I mean css attribute liek font-size:x-small. But it is from CSS standard and we use tinyMCE to edit some of HTML part and tinyMCE uses that named font-sizes.
Do you plan to add this feature?
Nonetheless it looks like I'll make a change for html2pdf. Where should I send my patch if it will be ready?

BTW didn't you thought that comments in English would make library much easier to use (the same goes about the site/forum)?

And thanks for a good library

Hi !

yes, named font-sizes could be added in a next version

http://www.w3schools.com/CSS/pr_font_font-size.asp

qrilka (./1) :
BTW didn't you thought that comments in English would make library much easier to use (the same goes about the site/forum)?

about website and forum, they are also in English

"Ouvrir dans une nouvelle fenêtre" sounds like you are right

BTW here a diff for the changes I made:
------
26,27d25
< var $absFontSizes = array('xx-small' => '9px', 'x-small' => '10px','small' => '13px', 'medium' => '16px',
< 'large' => '18px', 'x-large' => '24px', 'xx-large' => '24px');
674,678d671
< if (!is_numeric($val)) {
< if (isset($this->absFontSizes[$val])) {
< $val = $this->absFontSizes[$val];
< }
< }
-------
I does not take into account relative sizes though.
And also I stumbled upon some quite weird alignment issue. I'll post the details when I'll find the reson behind it.

What does your code do when the entry is not found? How is the default size defined?
if(isset(...) {...} else { ??? /*no entry found*/ }

Actually this code could be rewritten as
---
if (!is_numeric($val) && isset($this->absFontSizes[$val])) {
$val = $this->absFontSizes[$val];
}
---
and see later code in current implementation.
There should be no 'else' present as it makes no sense.

OK, I was just curious, I don't know the code.